Fix broken add track action
authorVirgil Dupras <hsoft@hardcoded.net>
Mon, 13 Jul 2015 18:31:56 +0000 (14:31 -0400)
committerVirgil Dupras <hsoft@hardcoded.net>
Mon, 13 Jul 2015 18:31:56 +0000 (14:31 -0400)
Fix the bug I've introduced in my PR #78, breaking the add
track/playlist action. We have to decode URIs before sending them back
to our socket!

fixes #80

htdocs/js/mpd.js

index 55acf6b..49a4656 100644 (file)
@@ -243,7 +243,7 @@ function webSocketConnect() {
                             "<span class=\"glyphicon glyphicon-" + glyphicon + "\"></span></a>")
                             .find('a').click(function(e) {
                                 e.stopPropagation();
-                                socket.send(onClickAction + "," + $(this).parents("tr").attr("uri"));
+                                socket.send(onClickAction + "," + decodeURI($(this).parents("tr").attr("uri")));
                             $('.top-right').notify({
                                 message:{
                                     text: $('td:nth-child(2)', $(this).parents("tr")).text() + " added"
@@ -264,7 +264,7 @@ function webSocketConnect() {
                                     app.setLocation("#/browse/0/"+$(this).attr("uri"));
                                     break;
                                 case 'song':
-                                    socket.send("MPD_API_ADD_TRACK," + $(this).attr("uri"));
+                                    socket.send("MPD_API_ADD_TRACK," + decodeURI($(this).attr("uri")));
                                     $('.top-right').notify({
                                         message:{
                                             text: $('td:nth-child(2)', this).text() + " added"
@@ -272,7 +272,7 @@ function webSocketConnect() {
                                     }).show();
                                     break;
                                 case 'plist':
-                                    socket.send("MPD_API_ADD_PLAYLIST," + $(this).attr("uri"));
+                                    socket.send("MPD_API_ADD_PLAYLIST," + decodeURI($(this).attr("uri")));
                                     $('.top-right').notify({
                                         message:{
                                             text: "Playlist " + $('td:nth-child(2)', this).text() + " added"