From: Hugo Villeneuve <hugo@hugovil.com>
Date: Sun, 17 Nov 2013 23:48:26 +0000 (-0500)
Subject: Make MUL and DIV use generic source/destination variables
X-Git-Tag: v2.0.0~83
X-Git-Url: http://gitweb.hugovil.com/?a=commitdiff_plain;h=f9394f5df4928130537d45c5b4e2359e17f8cd76;p=emu8051.git

Make MUL and DIV use generic source/destination variables

To remove confusing commented code and compilation warning
---

diff --git a/src/opcode2c.pl b/src/opcode2c.pl
index 79ff5ec..57810b8 100755
--- a/src/opcode2c.pl
+++ b/src/opcode2c.pl
@@ -289,11 +289,10 @@ for ($i=0 ; $i< 256; $i++) {
 	    if ($op_destination == 18) { # @A+DPTR
 		cfw("unsigned int destination = cpu8051_ReadD( _ACC_ ) + memory_sfr_read_dptr();");
 	    }
-# Mis en commentaire car donnait un warning (destination et source unused variables...)
-#	if ($op_destination == 20) { # AB
-#	    cfw("unsigned char destination = cpu8051_ReadD( _ACC_ );");
-#	    cfw("unsigned char source = cpu8051_ReadD( _B_ );");
-#	}
+            if ($op_destination == 20) { # AB
+                cfw("unsigned char destination = cpu8051_ReadD( _ACC_ );");
+                cfw("unsigned char source = cpu8051_ReadD( _B_ );");
+            }
 	    if ($op_destination == 21) { # DPTR
 		cfw("unsigned int destination = memory_sfr_read_dptr();");
 	    }
@@ -562,12 +561,14 @@ for ($i=0 ; $i< 256; $i++) {
 
 	# DIV
 	if ($insttype[$i] == 29) {
-	    cfw("unsigned char A = cpu8051_ReadD( _ACC_ ), B = cpu8051_ReadD( _B_ );");
+            # A = destination
+            # B = source
 	    cfw("psw_clr_cy();");
             # If B is zero, the OV flag will be set indicating a
             # division-by-zero error
-	    cfw("if ( B != 0 ) {");
-	    cfw("    cpu8051_WriteD( _ACC_, A/B ); cpu8051_WriteD( _B_, A%B );");
+	    cfw("if (source != 0) {");
+	    cfw("    cpu8051_WriteD(_ACC_, destination/source);");
+            cfw("    cpu8051_WriteD( _B_, destination%source);");
 	    cfw("    psw_clr_ov();");
 	    cfw("} else {");
 	    cfw("    psw_set_ov();");
@@ -590,10 +591,11 @@ for ($i=0 ; $i< 256; $i++) {
 
 	# MUL
 	if ($insttype[$i] == 31) {
-	    cfw("unsigned char A = cpu8051_ReadD( _ACC_ ), B = cpu8051_ReadD( _B_ );");
+            # A = destination
+            # B = source
 	    cfw("psw_clr_cy();");
-	    cfw("psw_clr_ov();");
-	    cfw("cpu8051_WriteD( _ACC_ , ( ( A * B ) & 0x00FF ) ); cpu8051_WriteD( _B_, ( A * B ) / 0x100 );");
+	    cfw("cpu8051_WriteD(_ACC_, destination * source);");
+            cfw("cpu8051_WriteD(_B_, (destination * source) / 0x100);");
 	    cfw("if (cpu8051_ReadD(_B_) > 0)");
 	    cfw("    psw_set_ov();");
 	    cfw("else");